volcano-sh / devices

Device plugins for Volcano, e.g. GPU
Apache License 2.0
103 stars 43 forks source link

Add vgpu-ci to device-plugin #39

Closed archlitchi closed 1 year ago

volcano-sh-bot commented 1 year ago

@archlitchi: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
volcano-sh-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/volcano-sh/devices/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wangyang0616 commented 1 year ago

The current PR is merged in, and every time a new PR is merged in the future, it will trigger the device to push a new image to Volcano-sh, right?

archlitchi commented 1 year ago

The current PR is merged in, and every time a new PR is merged in the future, it will trigger the device to push a new image to Volcano-sh, right?

yes,i think so

william-wang commented 1 year ago

Add the "username: ${{ secrets.DOCKERHUB_USERNAME }} password: ${{ secrets.DOCKERHUB_TOKEN }}" to fix the ci failure, so I have to merge it manually.