search

volcano-sh / devices

Device plugins for Volcano, e.g. GPU
Apache License 2.0
97 stars 41 forks source link

Fix ci failure #70

Closed SataQiu closed 1 week ago

SataQiu commented 1 month ago

TAG_VERSION and make push-tag was removed by https://github.com/volcano-sh/devices/pull/65 We need to update the CI task as well.

Failure history: https://github.com/volcano-sh/devices/actions/runs/8752334183/job/24019754773

volcano-sh-bot commented 1 month ago

Welcome @SataQiu!

It looks like this is your first PR to volcano-sh/devices.

Thank you, and welcome to Volcano. :smiley:

SataQiu commented 1 month ago

/assign @william-wang

william-wang commented 1 month ago

Thanks for your contribution. Please take a look at the FOSSA failure.

SataQiu commented 1 month ago

Hi @william-wang Thank you for your quick feedback. The CI failure is due to the fact that make push-tag target no longer exists in Makefile, and this PR is the solution for this problem. This fix does not work until the merge. So it seems like you need to check this PR and merge it manually.

Monokaix commented 1 month ago

Hi @william-wang Thank you for your quick feedback. The CI failure is due to the fact that make push-tag target no longer exists in Makefile, and this PR is the solution for this problem. This fix does not work until the merge. So it seems like you need to check this PR and merge it manually.

From the ci failure message:

image

seems that when checkout code, it didn't checkout to the current PR's commit, so your code is not executed actually.

And the correct checkout action is:

image

which is from https://github.com/volcano-sh/volcano/actions/runs/10284296442/job/28546801702

So I think we should refer to the volcano repo and modify the checkout the action job to solve the ci problem.

Monokaix commented 1 month ago

Maybe we can change

    steps:
      - uses: actions/checkout@v2
to
  - name: Checkout code
    uses: actions/checkout@v3
SataQiu commented 1 month ago

Good idea, thx @Monokaix PTAL.

Monokaix commented 1 month ago

Good idea, thx @Monokaix PTAL.

Seems it still didn't take effect: )

SataQiu commented 1 month ago

I think it will take effect after merge. @Monokaix @william-wang

Monokaix commented 1 week ago

Hi @william-wang Thank you for your quick feedback. The CI failure is due to the fact that make push-tag target no longer exists in Makefile, and this PR is the solution for this problem. This fix does not work until the merge. So it seems like you need to check this PR and merge it manually.

As the workflow of github action itself has some problem, so the ci is breakdown, and it's a cycle loop so we should merge it first to solve the ci issus.

Monokaix commented 1 week ago

/lgtm

Monokaix commented 1 week ago

cc @william-wang

william-wang commented 1 week ago

/approve

volcano-sh-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/volcano-sh/devices/blob/master/OWNERS)~~ [william-wang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment