search

volcano-sh / volcano

A Cloud Native Batch System (Project under CNCF)
https://volcano.sh
Apache License 2.0
3.91k stars 902 forks source link

Volcano support SidecarContainer #3513

Open Monokaix opened 3 weeks ago

Monokaix commented 3 weeks ago

What would you like to be added:

Add sidecarContainer support for volcano scheduler, which needs volcano scheduler re-compute pod resource requests.

Why is this needed:

SideCarContainer is a beta feature and is enabled by default in k8s v1.29, volcano has not yet adapt the feature, this may cause the scheduler to undercalculate the resources for the pod, and then the kubelet admit failed after the pod is scheduled to the node, because the sidecarcontainer is a new kind of initcontainer, so the pod initialization request resources need to be recalculated.

Refer to:

  1. https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/753-sidecar-containers#resources-calculation-for-scheduling-and-pod-admission
  2. https://github.com/kubernetes/kubernetes/pull/116429
Monokaix commented 3 weeks ago

/good-first-issue

volcano-sh-bot commented 3 weeks ago

@Monokaix: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/volcano-sh/volcano/issues/3513): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
7h3-3mp7y-m4n commented 3 weeks ago

hey, I would like to work on this /assign

babugeet commented 3 weeks ago

hey I would like to work on this

Monokaix commented 3 weeks ago

/assign @7h3-3mp7y-m4n

Monokaix commented 3 weeks ago

hey, I would like to work on this /assign

You're welcome to do that! And please pay a little attention that this feature is planned to release in next version v1.10, and we should make it merged before that: )

Monokaix commented 3 weeks ago

hey I would like to work on this

Very thanks but a little pity that @7h3-3mp7y-m4n has picked this issue first, you can take a look at other issues that you can contribute to: )

7h3-3mp7y-m4n commented 3 weeks ago

hey, I would like to work on this /assign

You're welcome to do that! And please pay a little attention that this feature is planned to release in next version v1.10, and we should make it merged before that: )

Okay, I try my best to complete it ASAP

Monokaix commented 2 weeks ago

@7h3-3mp7y-m4n Hi, there are some main changes need to be done