Garbage Collector is supposed to clean up Aborted volcanojobs

[Antsypc]

What happened: garbagecollector controller does not clean up any Aborted volcanojobs where the .status.state.phase is Aborted.

What you expected to happen: Aborted jobs should be cleaned up.

How to reproduce it (as minimally and precisely as possible):

1. create a volcanojob with .spec.ttlSecondsAfterFinished specified.
2. abort this job.
3. kubectl get vj xxx, you will see that thee job's .status.state.phase is Aborted.
4. wait for ttlSecondsAfterFinished seconds.
5. however, this job still exists.

Anything else we need to know?: The bug seems to occur in the following code. https://github.com/volcano-sh/volcano/blob/v1.10.0-alpha.0/pkg/controllers/garbagecollector/garbagecollector.go#L266

func isJobFinished(job *v1alpha1.Job) bool {
    return job.Status.State.Phase == v1alpha1.Completed ||
        job.Status.State.Phase == v1alpha1.Failed ||
        job.Status.State.Phase == v1alpha1.Terminated
}

The condition job.Status.State.Phase == v1alpha1.Aborted should not be omitted.

Environment:

• Volcano Version: 1.4 to 1.9, up to now

[Monokaix]

I think it's reasonable: )

[Monokaix]

/good-first-issue

[volcano-sh-bot]

@Monokaix: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/volcano-sh/volcano/issues/3604): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[kyooosukedn]

Would like to try on this :)

[googs1025]

/assign

[googs1025]

Would like to try on this :)

@kyooosukedn Oh! Do you want to try this topic? Then I'll give it to you first. I can help review it.

[googs1025]

/assign @kyooosukedn

[kyooosukedn]

3637

[googs1025]

I think the key question is: how do we distinguish between "Aborted", "Terminated", and "Failed"? Are these three states defined as the final state of the Job? I can't easily distinguish the difference between these three states of the Job in the code. Why do we need to divide them into three?

[googs1025]

So we must confirm one thing, which states are the final states. And these final states can be recycled by Garbage Collector

[Monokaix]

@Antsypc Can you describe that under what will you abort a job，and can the job be resumed by command vcctl job resume?

[Monokaix]

Aha, aborted job can be resumed: )

[googs1025]

Aha, aborted job can be resumed: )

Based on this result, I think the aborted state is not a final state.

[Monokaix]

Aha, aborted job can be resumed: )

Based on this result, I think the aborted state is not a final state.

Yeah！

[Monokaix]

@Antsypc Aborted is not a final state and can be resumed so we will close this.

[Monokaix]

/close

[volcano-sh-bot]

@Monokaix: Closing this issue.

In response to [this](https://github.com/volcano-sh/volcano/issues/3604#issuecomment-2261758131): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.