search

volcano-sh / volcano

A Cloud Native Batch System (Project under CNCF)
https://volcano.sh
Apache License 2.0
4.21k stars 964 forks source link

helm chart - remove hard coded nodeSelector for kubestatemetrics portion #3735

Closed dmildh-absci closed 1 month ago

dmildh-absci commented 1 month ago

Description

If you don't have the node label of control-plane on your cluster the metrics pod will not start. Consider making this a variable so you can provide your own node selector or provide affinity rules.

https://github.com/volcano-sh/volcano/blob/master/installer/helm/chart/volcano/templates/kubestatemetrics.yaml#L187-L190

Steps to reproduce the issue

Run the helm chart with Values.custom.metrics_enable = true

Describe the results you received and expected

The kube-state-metrics pod should start for clusters that are not using the control-plane label

What version of Volcano are you using?

volcano version: "1.5" appVersion: "0.1"

Any other relevant information

No response

Monokaix commented 1 month ago

/good-first-issue

volcano-sh-bot commented 1 month ago

@Monokaix: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/volcano-sh/volcano/issues/3735): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lekaf974 commented 1 month ago

@Monokaix opened this pr waiting for feedback