volcano-sh / volcano

A Cloud Native Batch System (Project under CNCF)
https://volcano.sh
Apache License 2.0
4.11k stars 949 forks source link

controllers: fix queue controller syncQueue bug #3742

Open sceneryback opened 1 week ago

sceneryback commented 1 week ago

Sometimes we may encounter podGroupNotFound errors when doing syncQueue, maybe due to misses of podGroup deletion events. In this case, we should try to re-enqueue the request and update local cache or the queue status will be left unchanged forever, e.g.

WeChatWorkScreenshot_a653b381-82d4-4b66-a40f-6d331e9881c6
volcano-sh-bot commented 1 week ago

Welcome @sceneryback!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. :smiley:

volcano-sh-bot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign monokaix You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/controllers/OWNERS](https://github.com/volcano-sh/volcano/blob/master/pkg/controllers/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sceneryback commented 5 days ago

/assign @monokaix

Monokaix commented 3 days ago

Please also squash to one commit and sign off with git commit -s.

sceneryback commented 3 days ago

Please also squash to one commit and sign off with git commit -s.

@Monokaix Thanks and done

Monokaix commented 2 days ago

/lgtm

volcano-sh-bot commented 2 days ago

New changes are detected. LGTM label has been removed.

sceneryback commented 2 days ago

hi @Monokaix just rebased the branch with master, please have a look

Monokaix commented 1 day ago

Hi, please check the failed ci.