volcano-sh / volcano

A Cloud Native Batch System (Project under CNCF)
https://volcano.sh
Apache License 2.0
4.24k stars 971 forks source link

Support colocation for computing workload and mircro-service #3789

Closed william-wang closed 3 weeks ago

william-wang commented 1 month ago

Implemention for https://github.com/volcano-sh/volcano/issues/3783

Monokaix commented 4 weeks ago

/ok-to-test

wangyang0616 commented 3 weeks ago

Does the online pod evict offline pod function depend on the preemption function of the Volcano? Does the preemption configuration need to be enabled?

wangyang0616 commented 3 weeks ago

Does network bandwidth isolation have dependency requirements on the CNI plug-in, for example, the specified CNI component or version?

Monokaix commented 3 weeks ago

Does the online pod evict offline pod function depend on the preemption function of the Volcano? Does the preemption configuration need to be enabled?

It just depends on eviction interface and will take PDB into consideration.

Monokaix commented 3 weeks ago

Does network bandwidth isolation have dependency requirements on the CNI plug-in, for example, the specified CNI component or version?

Currently no limitation.

wangyang0616 commented 3 weeks ago

/lgtm

Monokaix commented 3 weeks ago

/approve

volcano-sh-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/volcano-sh/volcano/blob/master/OWNERS)~~ [Monokaix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment