volcano-sh / volcano

A Cloud Native Batch System (Project under CNCF)
https://volcano.sh
Apache License 2.0
4.25k stars 971 forks source link

Remove deprecated Ginkgo options --progress and --slow-spec-threshold #3814

Open SherlockShemol opened 2 weeks ago

SherlockShemol commented 2 weeks ago

When I pr https://github.com/volcano-sh/volcano/pull/3811 and I find the E2E tests failed.When I investigate the problem, I find

You're using deprecated Ginkgo functionality:
=============================================
  --progress is deprecated .  The functionality provided by --progress was confusing and is no longer needed.  Use --show-node-events instead to see node entry and exit events included in the timeline of failed and verbose specs.  Or you can run with -vv to always see all node events.  Lastly, --poll-progress-after and the PollProgressAfter decorator now provide a better mechanism for debugging specs that tend to get stuck.
  --slow-spec-threshold is deprecated --slow-spec-threshold has been deprecated and will be removed in a future version of Ginkgo.  This feature has proved to be more noisy than useful.  You can use --poll-progress-after, instead, to get more actionable feedback about potentially slow specs and understand where they might be getting stuck.

This pr is to remove deprecated Ginkgo options --progress and --slow-spec-threshold.

volcano-sh-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/volcano-sh/volcano/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
SherlockShemol commented 2 weeks ago

For your reference: https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md#250

hwdef commented 1 week ago

But there are other errors in CI

SherlockShemol commented 1 week ago

But there are other errors in CI

Could this be due to resource limitations in the CI environment? It seems like the jobs are failing all the time.Or it's because of some resource allocation or scheduling problem.

hwdef commented 1 week ago

I'll check this

JesseStutler commented 1 week ago

Please rebase the new master branch because CI has been fixed: https://github.com/volcano-sh/volcano/pull/3817

SherlockShemol commented 1 week ago

Please rebase the new master branch because CI has been fixed: #3817

rebased.

hwdef commented 1 week ago

Please modify the describe. delete some useless errors. Such as,

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0005117f0>: 
      [Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0
      {
          s: "[Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0",
      }
  occurred
SherlockShemol commented 1 week ago

Please modify the describe. delete some useless errors. Such as,

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0005117f0>: 
      [Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0
      {
          s: "[Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0",
      }
  occurred

modified.

Monokaix commented 4 days ago

Is there some changs of ginkgo output for users when these flags are removed and new flags are added?

SherlockShemol commented 4 days ago

Is there some changs of ginkgo output for users when these flags are removed and new flags are added?

 Ginkgo's console output is not guaranteed to be stable for tooling and automation purposes. You should, instead, use Ginkgo's JSON format to build tooling on top of as it has stronger guarantees to be stable from version to version.

Yes, the console output may change and it has stronger guarantees if using the JSON format to build tooling on top of.