Open SherlockShemol opened 2 weeks ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng
You can assign the PR to them by writing /assign @kevin-wangzefeng
in a comment when ready.
The full list of commands accepted by this bot can be found here.
For your reference: https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md#250
But there are other errors in CI
But there are other errors in CI
Could this be due to resource limitations in the CI environment? It seems like the jobs are failing all the time.Or it's because of some resource allocation or scheduling problem.
I'll check this
Please rebase the new master branch because CI has been fixed: https://github.com/volcano-sh/volcano/pull/3817
Please rebase the new master branch because CI has been fixed: #3817
rebased.
Please modify the describe. delete some useless errors. Such as,
[FAILED] Unexpected error:
<*errors.errorString | 0xc0005117f0>:
[Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0
{
s: "[Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0",
}
occurred
Please modify the describe. delete some useless errors. Such as,
[FAILED] Unexpected error: <*errors.errorString | 0xc0005117f0>: [Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0 { s: "[Wait time out]: expected job 'qj-1' to have 2 ready pods, actual got 0", } occurred
modified.
Is there some changs of ginkgo output for users when these flags are removed and new flags are added?
Is there some changs of ginkgo output for users when these flags are removed and new flags are added?
Ginkgo's console output is not guaranteed to be stable for tooling and automation purposes. You should, instead, use Ginkgo's JSON format to build tooling on top of as it has stronger guarantees to be stable from version to version.
Yes, the console output may change and it has stronger guarantees if using the JSON format to build tooling on top of.
When I pr https://github.com/volcano-sh/volcano/pull/3811 and I find the E2E tests failed.When I investigate the problem, I find
This pr is to remove deprecated Ginkgo options --progress and --slow-spec-threshold.