search

volcano-sh / website

Volcano website and documentation repo: https://volcano.sh
Apache License 2.0
19 stars 49 forks source link

update & add favicons #179

Closed Arhell closed 2 years ago

Arhell commented 2 years ago

resolve https://github.com/volcano-sh/website/issues/178

Arhell commented 2 years ago

/assign @Thor-wl /assign @k82cn

I copied the header in order for the check to work, nothing has changed there https://github.com/volcano-sh/website/blob/master/themes/academic/layouts/partials/header.html

before in issue

after

https://realfavicongenerator.net/favicon_checker?protocol=https&site=deploy-preview-179--kind-montalcini-bed86a.netlify.app%2Fen%2F#.YkAnk-fP23A

Thor-wl commented 2 years ago

/lgtm /approve

volcano-sh-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/volcano-sh/website/blob/master/OWNERS)~~ [Thor-wl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment