volcano-sh / website

Volcano website and documentation repo: https://volcano.sh
Apache License 2.0
19 stars 49 forks source link

add svg slack icon #231

Closed Arhell closed 2 years ago

Arhell commented 2 years ago

resolve https://github.com/volcano-sh/website/issues/230

volcano-sh-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign thor-wl You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/volcano-sh/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Arhell commented 2 years ago

/assign @Thor-wl

Thor-wl commented 2 years ago

I'm not an expert of front end and design. May I ask that why replace the png with svg? I see there seems to be smaller pixel.

Arhell commented 2 years ago

I'm not an expert of front end and design. May I ask that why replace the png with svg? I see there seems to be smaller pixel.

that's right, the icon is better and the pixels will not be visible

kevin-wangzefeng commented 2 years ago

Thanks @Arhell , I'd like to confirm if the logo comes from cncf/artwork (which is considered as the canonical source).

kevin-wangzefeng commented 2 years ago

https://github.com/cncf/artwork

Arhell commented 2 years ago

I'd like to confirm if the logo comes from cncf/artwork (which is considered as the canonical source).

no, there is no slack, I updated it and took it from https://brandfolder.com/slack/logos

and min svg

kevin-wangzefeng commented 2 years ago

Sorry, I misunderstood the PR. It looks fine to me then, could you reopen it?

Arhell commented 2 years ago

Sorry, I misunderstood the PR. It looks fine to me then, could you reopen it?

I can't reopen, I deleted the branch, I’ll open a new one later

kevin-wangzefeng commented 2 years ago

Sure, thanks