search

voldikss / vim-floaterm

:computer: Terminal manager for (neo)vim
MIT License
2.47k stars 78 forks source link

floaterm.cmd has wrong string not-equal comparison #361

Closed yantongl closed 2 years ago

yantongl commented 2 years ago

The problem

When running floaterm <filename> in the float term window, I saw this error message: != was unexpected at this time.. After some digging, apparently in floaterm.cmd, the string not-equal comparison is incorrect.

In the current version, the script is written as:

IF "%NVIM_LISTEN_ADDRESS%" != "" GOTO neovim
IF "%NVIM%" != "" GOTO neovim

Based on my testing and this page, string not-equal comparison should be written as IF NOT "something" == "something" or IF "something" NEQ "something".

My Environment

Neovim 0.7.0

my :checkhealth floaterm result:

floaterm: health#floaterm#check
========================================================================
## common
  - INFO: Platform: win
  - INFO: Nvim: NVIM v0.7.0
  - INFO: Plugin: 875c404

## terminal
  - OK: Terminal emulator is available

## floating
  - OK: Floating window is available
voldikss commented 2 years ago

Fixed, thanks.

yantongl commented 2 years ago

That's fast response! Thank you!