feat: add `--cwd=<buffer-root>` option

voldikss / vim-floaterm

:computer: Terminal manager for (neo)vim

MIT License

2.46k stars 79 forks source link

feat: add `--cwd=<buffer-root>` option #420

Closed hasundue closed 8 months ago

hasundue commented 9 months ago

This PR adds a literal for the --cwd option, namely <buffer-root>, which represents the project root directory of the active buffer. This fits my use case, and possibly others I hope, like when editing config files for my vim/neovim placed in a dedicated repository while I'm working on a regular project.

hasundue commented 9 months ago

Now I'm figuring out what exactly the linter is arguing. Help from experts would be appreciated. https://github.com/hasundue/vim-floaterm/actions/runs/6636731103/job/18029690613

hasundue commented 8 months ago

Sorry for leaving this for long. Turned it ready for review since vint CI seems broken now anyway.

Floaterm might not be super welcome about a PR for feature addition, which I was not aware of. In that case the change in floaterm#path#get_root alone would be helpful enough for me.

voldikss commented 8 months ago

Sorry for the late response, I was just too busy to review the PR or fix bugs. I think adding option makes sense in the case. Merged, thank you for the PR!