Convert missed hard coded strings

[okrych]

@shawnlauzon I rebased my working branch, please check it Thanks

[shawnlauzon]

I don't understand what you're saying. I'm fairly confident that it works as I think, so do your best and I'll make fixes necessary.

On Wed, Jul 25, 2018, 11:48 PM rogiermuijen, notifications@github.com wrote:

@rogiermuijen commented on this pull request.

In venue/lang/en-CA.js https://github.com/Volentix/venue-client/pull/244#discussion_r205324356:

@@ -97,8 +100,14 @@ module.exports = { title: "Points / rewards detailed info", posts_sitewide: "0 posts sitewide | 1 post sitewide | { count } posts sitewide",

• points_sitewide:
• "0 points sitewide | 1 points sitewide | { count } points sitewide",
• posts_sitewide_text:

Yes, it will work if the mix of the various pieces is all for the math formula, like this

{{ bonus_level.num_posts }} posts sitewide X {{ 100 + bonus_level.bonus_percentage }} = {{ bonus_level.num_posts * (100 + bonus_level.bonus_percentage) }} Points

In the above example, we can get two language items

{{ bonus_level.num_posts }} posts sitewide {{ bonus_level.num_posts * (100 + bonus_level.bonus_percentage) }} Points

so if we convert it, it will be like this

5 posts sitewide X 2 = 10 Points

but if it is for the sentence, this pattern will cause problems for other languages

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Volentix/venue-client/pull/244#discussion_r205324356, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlUyZfF0LQTXIJtD__w5uEwtPrEeAILks5uKTwngaJpZM4Vg2oC .

[okrych]

Yes, sure Thanks 👍