Closed shawnlauzon closed 6 years ago
Please make sure the file contains all the phrases which needs to be translated.
After seeing the commit from @alexdashkov, I've realized that putting all the HTML in the .po
file is a bad idea (hadn't really thought it through). The entire file should be translated.
However, the other question is if we should really be sending Turkish referrals to all the friends of a Turkish user? Or should the referral email be sent in English? This is a question for @volentixnonton11 or @vlabs-mar.
@Mojganahk Please confirm if a bilingual email could make sense. (As far as restrictions on gmail)
@Mojganahk asked for all of the options. Here they are that I can think of:
Let me know what @Mojganahk and @volentixnonton11 decide.
5 and 7 seem most appropriate to me.
Sending only Turkish emails is ruled out because if it is an English receiver and they flag as spam because it's Turkish and they can't understand anything that has long term threat attached.
@mojganhk ?
On Fri, Aug 17, 2018 at 1:42 PM, Shawn Lauzon notifications@github.com wrote:
@Mojganahk https://github.com/Mojganahk asked for all of the options. Here they are that I can think of:
- Always send English email
- Send Turkish email if sender is Turkish
- Drop down on client side choosing language to send all emails in
- Drop down on client side choosing language to send each email in
- Send English email if sender is Turkish, but that also includes a link to a hosted copy of the referral email in Turkish (this hosted version in fact can display the referral link if we host the email on Venue)
- Send all languages in email (probably won't fit)
- Shrink the size of the email content in order to put all languages (might fit for ~2 languages)
Let me know what @Mojganahk https://github.com/Mojganahk and @volentixnonton11 https://github.com/volentixnonton11 decide.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Volentix/venue-server/issues/181#issuecomment-413938910, or mute the thread https://github.com/notifications/unsubscribe-auth/AmMCiHIBGBjaIN9vIzxAcuZGCATZkMxeks5uRwCCgaJpZM4V-cFe .
@volentixnonton11 @shawnlauzon Number 5 can be a good option.
It looks like the referral bonus email text messages are not part of the translation file, which means they can't be translated. These need to be added to the
.po
file and then sent to translation.cc @Mojganahk