search

volentixlabsinc / venue-server

The backend services for Venue, a community engagement platform for the Volentix community
https://venue.volentix.io
MIT License
6 stars 0 forks source link

Fix forum rank doesn't exist #203

Closed alexdashkov closed 6 years ago

alexdashkov commented 6 years ago

Closes #202. Do not raise an exception when forum rank doesn't exist

shawnlauzon commented 6 years ago

@alexdashkov I still don't think this resolves the problem. The issue is that "Copper Member" is not an acceptable rank, and so a failure is displayed about not being able to find the user, when the real error is that a) the user could be found, but b) could not parse the rank.

alexdashkov commented 6 years ago

@shawnlauzon the failure is being displayed that user's rank doesn't exist in the venue DB. Including all the context (user, profile, etc.. ) so you (or someone else) can decide to add or not this rank to the database.

shawnlauzon commented 6 years ago

There should be a migration that populates the database with content. That migration should contain a new item "Copper Member"

On Sat., Aug. 25, 2018, 5:00 p.m. Oleksandr, notifications@github.com wrote:

@shawnlauzon https://github.com/shawnlauzon the issue is being diplayed that user's rank doesn't exist in the venue DB. Including all the context (user, profile, etc.. ) so you (or someone else) can decide to add or not this rank to the database.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Volentix/venue-server/pull/203#issuecomment-415996223, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlUyWIVrotWGGF8UX4L6F9BEd-vfYQJks5uUbrfgaJpZM4WGVZp .

shawnlauzon commented 6 years ago

Fixture sounds better, thank you.

On Sun., Aug. 26, 2018, 11:56 a.m. Oleksandr, notifications@github.com wrote:

Do you mind if I use the fixture instead? This data should not be in migrations. Read more https://docs.djangoproject.com/en/2.1/howto/initial-data/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Volentix/venue-server/pull/203#issuecomment-416048886, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlUyQtA1KIm3kvdAc-rBmKLHzNd8GSoks5uUsU_gaJpZM4WGVZp .

alexdashkov commented 6 years ago

@shawnlauzon I've added this rank to the django fixtures and call of this fixture to the entrypoint.sh. Do you execute this file during the deployment?

shawnlauzon commented 6 years ago

@alexdashkov truthfully, I'm not sure. Will merge it and see what happens :)