volkamerlab / KinaseFocusedFragmentLibrary

Subpocket-based fragmentation and recombination of kinase inhibitors
MIT License
6 stars 0 forks source link

Specify * imports #15

Closed dominiquesydow closed 4 years ago

dominiquesydow commented 4 years ago

@jaimergp question from #10:

Are you using __all__ = ["names", "you", "want", "to", "export", "to", "*"]? Otherwise we might overexporting too many symbols.

dominiquesydow commented 4 years ago

@jaimergp - if Paula's package in its current form will only be used via the CLI, do I only need to import the CLI main methods?

Whenever we refactored Paula's code, I am up for including also non-CLI function in __all__.

# kinase_focused_fragment_library/__init__.py
from . import preprocessing
from . import fragmentation
from . import recombination
# kinase_focused_fragment_library/preprocessing/__init__.py
from .cli import main
# kinase_focused_fragment_library/fragmentation/__init__.py
from .cli import main
# kinase_focused_fragment_library/recombination/__init__.py
from .cli import main
dominiquesydow commented 4 years ago

It seems to work like this :)