volkamerlab / opencadd

A Python library for structural cheminformatics
https://opencadd.readthedocs.io
MIT License
89 stars 18 forks source link

Refactor pocket module #59

Closed dominiquesydow closed 3 years ago

dominiquesydow commented 3 years ago

Description

This PR started with me realizing that so far I have only allowed anchor residue definitions by residue PDB IDs but not by residue KLIFS IDs (which is needed for e.g. the kissim module).

Then this PR evolved into a bigger refactoring, where the methods of the classes Subpocket and AnchorResidue are moved to Pocket, since only Pocket contains the full atomic data, which is needed to calculate anchor residues and subpockets. Subpocket and AnchorResidue mainly contain attributes and properties (but no methods).

Todos

Questions

None.

Status

codecov-io commented 3 years ago

Codecov Report

Merging #59 (6b2dd68) into master (a9da35e) will decrease coverage by 1.91%. The diff coverage is 65.74%.

dominiquesydow commented 3 years ago

This PR is superseded by #66 (contains latest changes from master).