search

volkamerlab / opencadd

A Python library for structural cheminformatics
https://opencadd.readthedocs.io
MIT License
89 stars 18 forks source link

Pylint RecursionError #63

Closed dominiquesydow closed 2 years ago

dominiquesydow commented 3 years ago

Since yesterday, I am running into a pylint recursion error.

Check out the failed CI: https://github.com/volkamerlab/opencadd/runs/1565679662

The same setup (at least regarding the above mentioned versions) did work 3 days ago: https://github.com/volkamerlab/opencadd/runs/1552066336

Locally, I can reproduce this error with Python 3.8.6 - pylint passes with 3.7.6 though.

Maybe related: https://github.com/PyCQA/pylint/issues/2388

Potential next steps:

jaimergp commented 3 years ago

There's plenty of opened issues on their repo about that now, so I'd ignore the linting errors for now and proceed normally. I am sure they'll fix it very soon.

jaimergp commented 3 years ago

You can pin astroid for a quick, temporary solution: https://github.com/PyCQA/pylint/issues/3982#issuecomment-745236956

dominiquesydow commented 3 years ago

Interestingly, at the moment it is working again for me, I have no clue why. Check e.g. this CI run: https://github.com/volkamerlab/opencadd/runs/1572712406

If I encounter the problem again, I will pin astroid.

jaimergp commented 3 years ago

Some people have mentioned it's a bit stochastic 🤷

dominiquesydow commented 3 years ago

Would you therefore pin astroid as a precaution?

jaimergp commented 3 years ago

It wouldn't hurt! But do leave this open so we remember to unpin it in the future :)

tofutofu commented 3 years ago

Just run into this issue also. I get the error 

F0002: <class 'RecursionError'>: maximum recursion depth exceeded while calling a Python object (astroid-error)

when my source file has:

from pandas import DataFrame

but if I change that to

import pandas as pd

it doesn't error... until I actually use pd.DataFrame.

python 3.7.9
pylint                    2.6.0            py37hc8dfbb8_1    conda-forge
pytest-pylint             0.18.0             pyhd3deb0d_0    conda-forge
astroid                   2.4.2            py37hc8dfbb8_1    conda-forge
pandas                    1.1.5            py37h010c265_0    conda-forge
dominiquesydow commented 2 years ago

Closing this issue because I have not encountered it for quite some time (maybe package updates fixed this?).