Fetch information for multiple kinases with _one_ API call

[dominiquesydow]

Description

Fetch information for multiple kinases with one API call (faster, cleaner!).

Todos

• [x] Pass multiple kinase names to KLIFS API Information.get_kinase_ID(kinase_name=kinase_names, species=species); previously per kinase one API call

Questions

• [x] In KLIFS API Information.get_kinase_ID(kinase_name=kinase_names, species=species), the kinase_name parameter seems to allow multiple kinase names only as string (e.g. "ABL1, EGFR") instead of a list of strings (e.g. ["ABL1", "EGFR"])
  • List of strings raises ValidationError:

    Failed validating 'type' in schema:
    {'description': 'The name (or multiple names separated by a comma) of '
                    '(a) specfic kinase(s) (e.g. ABL1).',
     'in': 'query',
     'name': 'kinase_name',
     'required': True,
     'type': 'string'}

  • Ask @AJK-dev if this behavior is intended

Status

• [x] Ready to go

[codecov-commenter]

Codecov Report

Merging #75 (eeb8d4c) into master (8a03435) will decrease coverage by 0.02%. The diff coverage is 100.00%.

[AJK-dev]

Good stuff :-) For historical reasons we initially defined a few calls this way and therefore explicitly documented this deviation in the description. However, earlier this week the renewed API (with a lot of input from you!) has been made available at https://klifs.net/swagger_v2/ The calls that previously required a string are now defined as a list/array!

[dominiquesydow]

Thank you, @AJK-dev! Do you already know when the KLIFS Swagger v2 will become the default? I am only asking to know if I should allocate some time sooner than later to get the changes integrated in opencadd.

Note to myself:

• Swagger definitions are done here: https://github.com/volkamerlab/opencadd/blob/8a03435dc2c3093b9f67e251aa0f57149e2c1328/opencadd/databases/klifs/remote.py#L874
• This PR already started to integrate new features from KLIFS Swagger v2: https://github.com/volkamerlab/opencadd/pull/55

[AJK-dev]

Thank you, @AJK-dev! Do you already know when the KLIFS Swagger v2 will become the default? I am only asking to know if I should allocate some time sooner than later to get the changes integrated in opencadd.

Note to myself:

• Swagger definitions are done here: https://github.com/volkamerlab/opencadd/blob/8a03435dc2c3093b9f67e251aa0f57149e2c1328/opencadd/databases/klifs/remote.py#L874
• This PR already started to integrate new features from KLIFS Swagger v2: #55

@dominiquesydow: V2 of the API will stay in beta for a while longer, but the paths will not change anymore. Probably only minor changes and possibly new functions will be added, the original version of the API will remain available for backward compatibility.