volkamerlab / teachopencadd

TeachOpenCADD: a teaching platform for computer-aided drug design (CADD) using open source packages and data
https://projects.volkamerlab.org/teachopencadd
Creative Commons Attribution 4.0 International
713 stars 197 forks source link

T011/23 + GHA??: Going through notebooks, checked also text and grammar #349

Closed f-sod closed 1 year ago

f-sod commented 1 year ago

Description

Proofreading of the six last talktorials and readme files.

Todos

Status

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

dominiquesydow commented 1 year ago

@AndreaVolkamer, why does this PR want to merge DL_edition from master? Should it not be something like "merge DL_edition from something like dl-proofread"?

Adding all these DL-related PRs to the base PR for the DL edition --- which is still this one, is it not? --- would help with getting an overview of all the open PRs or does this overview live somewhere else?

dominiquesydow commented 1 year ago

@AndreaVolkamer and @f-sod I see now that this PR description does not match the changes made (i.e. GHA, T=11, T023)? Can you please update the PR description to outline the intent of this PR?

f-sod commented 1 year ago

@AndreaVolkamer and @f-sod I see now that this PR description does not match the changes made (i.e. GHA, T=11, T023)? Can you please update the PR description to outline the intent of this PR?

@dominiquesydow I've updated the description with what was done, since I've only worked on the last 6 talktorials I don't know what changes you're talking about for the T023 ..

mbackenkoehler commented 1 year ago

@f-sod I don't see any reason to update the DL_edition branch this way. If you do work on the DL_edition branch, please create a branch starting there and corresponding to a particular issue. Then that issue branch should be merged back into DL_edition once you are finished with the work.