volkamerlab / teachopencadd

TeachOpenCADD: a teaching platform for computer-aided drug design (CADD) using open source packages and data
https://projects.volkamerlab.org/teachopencadd
Creative Commons Attribution 4.0 International
707 stars 196 forks source link

Conda packaging: env failure #390

Open dominiquesydow opened 1 year ago

dominiquesydow commented 1 year ago

Conda packaging for 2023.05.2 fails due to

The reported errors are:
- Encountered problems while solving:
   - nothing provides __cuda needed by pytorch-1.13.0-cuda112py310he33e0d6_200

---

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {MatchSpec("pytorch==1.13.0=cuda112py310he33e0d6_200"), MatchSpec("__cuda")}

Full logs: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=717588&view=logs&jobId=656edd35-690f-5c53-9ba3-09c10d0bea97&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

Ideas

dominiquesydow commented 1 year ago

I am trying pytorch from the conda-forge channel for our teachopencadd conda package here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=717595&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97

-> This seems to work for conda-forge, their CI is passing.

dominiquesydow commented 1 year ago

Pinging @AndreaVolkamer and @mbackenkoehler, could you please check with the DL team if the switch of channels still works fine for the DL talktorials?

AndreaVolkamer commented 1 year ago

@PaulaKramer @joschka-gross @Old-Shatterhand can you comment on this?

Old-Shatterhand commented 1 year ago

That's an interesting error.

Intuitively, I would have said, it doesn't matter. To be on the safe side, adjust the CI/CD pipeline on GitHub and test it.

But then I checked the actual conda-packages on their respective channels: conda-forge and PyTorch. They are not just copies of each other (as it is the case for RDKit, afaik). The conda-forge version has no support for win-64 and is one minor version behind the PyTorch channel. Also, the conda-forge builds are way smaller than the PyTorch builds. So, I'd say, the packages are not identical (as it might be the case for RDKit), but I doubt that they differ substantially and will brake the notebooks.

TL;DR: I'd update the CI/CD pipeline to conda-forge packages of PyTorch and rerun it. It will not work for Windows (as there is just no win-64 build of PyTorch on conda-forge), but I think on general Linux/MaxOS, this should not change the behavior of the notebooks.

AndreaVolkamer commented 1 year ago

adressed in https://github.com/volkamerlab/teachopencadd/pull/394

AndreaVolkamer commented 1 year ago

We will continue to work on this, but will merge the post-release fixes for now.