Invalid PAC-script terminates with an exception instead of using other strategies

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Configure proxy-vole to use a number of strategies, i.e. Browser, OS, EnvVar
2. Having the Browser use a PAC script with invalid content, in my case an 
invalid IpRange, unfortunately I do not have access to the actual PAC script 
that was used here
3. During setting up the ProxySelector, it fails with an exception about the 
invalid whitelist entry, the exception is thrown out of the 
ProxySearch.getProxySelector() call

What is the expected output? What do you see instead?

* I would expect an error message in the log and the next strategy to be used, 
i.e. OS in my case

What version of the product are you using? On what operating system?

* 20120727, but I compared with current trunk and there were no changes that 
would change this in the latest version

Please provide any additional information below.

* Stacktrace: 

Caused by: java.lang.IllegalArgumentException: IP range is not 
valid:http://10.*.*.*
at com.btr.proxy.selector.whitelist.IpRangeFilter.<init>(IpRangeFilter.java:32)
at 
com.btr.proxy.selector.whitelist.DefaultWhiteListParser.parseWhiteList(DefaultWh
iteListParser.java:39)
at 
com.btr.proxy.selector.whitelist.ProxyBypassListSelector.<init>(ProxyBypassListS
elector.java:54)
at 
com.btr.proxy.search.browser.ie.IEProxySearchStrategy.setByPassListOnSelector(IE
ProxySearchStrategy.java:140)
at 
com.btr.proxy.search.browser.ie.IEProxySearchStrategy.createFixedProxySelector(I
EProxySearchStrategy.java:122)
at 
com.btr.proxy.search.browser.ie.IEProxySearchStrategy.getProxySelector(IEProxySe
archStrategy.java:46)
at com.btr.proxy.search.ProxySearch.getProxySelector(ProxySearch.java:193)
... 34 more

Original issue reported on code.google.com by Dominik....@gmail.com on 10 Apr 2013 at 1:26

[GoogleCodeExporter]

Actually I could reproduce this by setting a proxy manually in the IE 
connection settings and adding an invalid item in the exclude-list under 
"Exceptions", i.e. if you put an invalid entry "http://10.*.*.*" in there.

Original comment by Dominik....@gmail.com on 11 Apr 2013 at 9:07

[GoogleCodeExporter]

Hi,
I fixed this issue with a more robust white list parser. I tested it with your 
example and now the wrong white list definition entry will be ignored.

I will release this with a new version.

- Rossi

Original comment by rosstaus...@googlemail.com on 9 Dec 2013 at 10:13

• Changed state: Fixed