search

volks73 / cargo-wix

A cargo subcommand to build Windows installers for rust projects using the WiX Toolset
https://volks73.github.io/cargo-wix
Apache License 2.0
306 stars 25 forks source link

packaging wrong bin in cross builds #150

Closed cstkingkey closed 2 years ago

cstkingkey commented 2 years ago

running cargo wix --target=i686-pc-windows-msvc the buiding stage trigger right binary out, and msi file do have a x86 name, but the bin in the msi is 64bit version.

volks73 commented 2 years ago

I am not too familiar with the cross-compilation support. It was mostly spread-headed by @roblabla. Maybe @roblabla can provide some information on cross-compilation with the --target option?

roblabla commented 2 years ago

At work, we use cargo-wix with --no-build along with --target, so it's possible --target has a bug. Maybe I forgot to propagate the target down to cargo build?

I'll look into it tomorrow.

cstkingkey commented 2 years ago

use $(var.CargoTargetBinDir) instead in wxs make it work.

cstkingkey commented 2 years ago

turn out the wxs is generated by 0.3.1. so latest version has no such issue.