search

volks73 / cargo-wix

A cargo subcommand to build Windows installers for rust projects using the WiX Toolset
https://volks73.github.io/cargo-wix
Apache License 2.0
306 stars 25 forks source link

republish docs #265

Closed Gankra closed 9 months ago

Gankra commented 9 months ago

there's docs on the new configs added in the last release, needs a deploy.

volks73 commented 9 months ago

I thought I did republish the docs to https://volks73.github.io/cargo-wix/cargo_wix when I created the most recent release, v0.3.8. I did cargo xtask ghp, which is supposed to automatically run rustdoc and push the changes to GitHub Pages. It is possible that failed in some hidden way.

Is the missing configs docs for the library or the binary (subcommand)? I believe the library documentation is handled through docs.rs, but I could be wrong on this.

Which configs docs are missing from the published docs? I would like to debug a little the xtask or docs.rs.

Gankra commented 9 months ago

Oh shit, you did! Thanks!

I could have sworn it wasn't updated yesterday, but maybe... caching..?

Gankra commented 9 months ago

image

Ah i see what messed me up. Yesterday I went to the docs specifically to make sure banner/dialog/product-icon were properly listed here, and I could have sworn I added them, but, I guess I lost it in a rebase or something (the new docs do have my updates to the individual entries for those, so I did land the most important docs).

Oh well, I'll submit a followup pr to add those.

volks73 commented 9 months ago

caching..?

I had the same thought after I posted my comment.

Oh well, I'll submit a followup pr to add those.

Sounds good. I will review, merge, and republish the docs with the new PR. Thank you for typing up the documentation.

volks73 commented 9 months ago

I have republished the docs: https://volks73.github.io/cargo-wix/cargo_wix/#configuration.

I see the new fields in the example configuration.