search

volks73 / cargo-wix

A cargo subcommand to build Windows installers for rust projects using the WiX Toolset
https://volks73.github.io/cargo-wix
Apache License 2.0
306 stars 25 forks source link

initial .wxs uses `encoding='windows-1252'` #293

Open juliusl opened 3 months ago

juliusl commented 3 months ago

I noticed that this encoding was used instead of UTF-8. The consequence of not using UTF-8 is that wix convert (wix3 -> wix4) will fail silently.

Workaround is to just change it to encoding='utf-8'. Interestingly enough wix convert ends up removing the xml tag all together.

volks73 commented 3 months ago

Does changing to utf-8 fail with wix3?

juliusl commented 3 months ago

@volks73 wix3/cargo-wix appears to work with utf-8