search

volkszaehler / libsml

Implementation in C of the Smart Message Language (SML) protocol
GNU General Public License v3.0
88 stars 49 forks source link

squash merged the Andreas Moog changes excluding .gitlab-ci.yml #111

Closed narc-Ontakac2 closed 1 year ago

narc-Ontakac2 commented 1 year ago

These are simply the squashed commits from #72 and a minor change to get the debuild going again.

r00t- commented 1 year ago

@narc-Ontakac2: good that you're taking this on!

r00t- commented 1 year ago

@narc-Ontakac2: i would word the commit message differently (can we just leave Andreas as the author of the squashed commit?) other than that, i'd merge this immediately.

r00t- commented 1 year ago

@narc-Ontakac2: many thanks. to me, "(squashed) debian packaging changes" or "(squashed) changes from debian packaging repository" would appear to be the correct commit message. (as the action of merging is not the author's.) maybe even as the generic autogenerated merged commit message generated by git. (i will try to get your added to the project so you can merge to master yourself as you see fit.)

r00t- commented 1 year ago

@narc-Ontakac2: you should have access to merge this yourself now, and have my approval to do so, but consider my note above.