search

volkszaehler / libsml

Implementation in C of the Smart Message Language (SML) protocol
GNU General Public License v3.0
88 stars 49 forks source link

hexdump() compatibility issue with newest Arduino / ESP8266 libraries #113

Closed mh-er closed 1 year ago

mh-er commented 1 year ago

There is a name collision of function hexdump() in libSML/sml/src/sml_shared.c and libSML/sml/include/sml_shared.h with the newest Arduino / ESP8266 libraries.

Proposal: rename to sml_hexdump()

r00t- commented 1 year ago

https://github.com/volkszaehler/libsml/blob/74e18fccc15bbd881a59befae1f6222f7047921d/sml/src/sml_shared.c#L165

r00t- commented 1 year ago

https://github.com/volkszaehler/libsml/blob/74e18fccc15bbd881a59befae1f6222f7047921d/sml/include/sml/sml_shared.h#L110

i wonder if this is part of our public API and if we break any compatibility by removing it?

but a function with such a generic name should not have been exported anyway, and hopefully nobody ever used it.

narc-Ontakac2 commented 1 year ago

If a version bump is desired - I'll do a release as a basis for a debian package release soon. I'd suggest I'll go to 1.1.0 instead of 1.0.2 and you merge this PR before.

mh-er commented 1 year ago

Saw your message just now. I re-based to the latest master. So you could take over the PR.

narc-Ontakac2 commented 1 year ago

Unfortunately I am the packager. All I do in this project is maintaining the debian packaging. So +1 for me for merging this, but I am not the one to do it.

r00t- commented 1 year ago

@narc-Ontakac2: please do the version bump, i'll merge

narc-Ontakac2 commented 1 year ago

The merge comes first. I'll then do a release 1.1.0 and from that a Debian release.

narc-Ontakac2 commented 1 year ago

Since @r00t- decided to merge I did it. Release 1.1.0 will follow.