search

volkszaehler / libsml

Implementation in C of the Smart Message Language (SML) protocol
GNU General Public License v3.0
85 stars 49 forks source link

Debian changes #142

Closed narc-Ontakac2 closed 8 months ago

narc-Ontakac2 commented 8 months ago

These are changes that were in the debian branch but can as well be applied to the master and changes that will help me doing official Debian releases.

I am doing this because I found using a single debian branch for all official Debian releases unmaintainable. Disadvantage of this approach is that I will create one debian- branch for every official Debian release. I hope this is acceptable.

If this works well I will do the same for vzlogger.

r00t- commented 8 months ago

what was the reason not to do the packages straight off master?

narc-Ontakac2 commented 8 months ago

This is because the Debian package should not be a native package, see https://www.debian.org/doc/debian-policy/ch-source.html. This is not against Debian policy, but Debian developers generally advise against it.

There are several reasons:

  1. Our packages are signed with a key that is uploaded to Github. For a Debian release it has to be signed with my Debian maintainer key that I consider very sensitive and that I will not upload to Github.
  2. Our package gets a different version number than the Debian package. This can be helpful in case of stupid packaging mistakes that are only relevant for Debian.
  3. The Debian package has slightly more modern settings in Debian control since it is only meant for Trixie. This will be more relevant for vzlogger because there will be a dependency on openssl >= 3.0 for the Debian package. This makes builds for buster impossible.
narc-Ontakac2 commented 8 months ago

Are these good reasons or do you object to a merge?

r00t- commented 8 months ago

i'm not objecting to a merge! i was only asking why you maintain a separate debian branch at all. feel free to merge as you see fit.