install.sh gives "Unknown argument -ENABLE_MQTT=on" error

[Piranha1511]

Hi,

I followed following instruction: https://wiki.volkszaehler.org/software/controller/vzlogger/installation_cpp-version

As soon as I use the command "./install.sh vzlogger libjson libsml mqtt" I get the following errors:

1. libsml: error: message type 0900 not yet implemented
2. CMake Error: Unknown argument -ENABLE_MQTT=on

I've tried it with Raspbian Lite and also with DietPi. Both with the same results.

System was updated before with apt update and apt upgrade.

[Piranha1511]

[narc-Ontakac2]

As a workaround you can try our Debian packages (see the bottom of the README.md). They have MQTT enabled.

[narc-Ontakac2]

"error: message type 0900 not yet implemented" is a successful test, that checks for an error message. I have adapted the title.

[r00t-]

this is caused by a trivlal syntax error in install.sh, it seems that nobody ever tried to use the mqtt option before.

i would personally vote to remove install.sh, it's some attempt to make source installation easier, in a nonstandard ad-hoc way, and it's failing, as demonstrated here. we have (deb) packaging now, the issues that install.sh tries to solve (installation of dependencies) should have better and more standardized soltions. i.e. we have a redundant one with the dockerfile (which might aswell invoke install.sh, but chooses not to..

[fm-maniac]

I used install.sh with mqtt option several times to update vzlogger and it worked. Lately to update to 0.8.3.

Am 30. Januar 2024 20:32:17 MEZ schrieb "Thorben T." @.***>:

this is caused by a trivlal syntax error in install.sh, it seems that nobody ever tried to use the mqtt option before.

i would personally vote to remove install.sh, it's some attempt to make source installation easier, in a nonstandard ad-hoc way, and it's failing, as demonstrated here. we have (deb) packaging now, the issues that install.sh tries to solve (installation of dependencies) should have better and more standardized soltions. i.e. we have a redundant one with the dockerfile (which might aswell invoke install.sh, but chooses not to..

-- Reply to this email directly or view it on GitHub: https://github.com/volkszaehler/vzlogger/issues/621#issuecomment-1917746049 You are receiving this because you are subscribed to this thread.

Message ID: @.***> -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

[r00t-]

left a comment at the commit this was introduced at: https://github.com/volkszaehler/vzlogger/commit/27eb8d1566ec493d9cf64d2b53676c846ebb6e35#r138085452

i wonder where the -<var>=<value> instead of -D<var>=<value> syntax to set a variable came from, at least my version of cmake does not have it, i cant find a mention of it in any documentation, at https://github.com/volkszaehler/vzlogger/issues/621 a user reports it doesn't work for him, while others report it's working.

[r00t-]

@fm-maniac: i'd like to understand how that code worked for you... would appreciate if you could reproduce that and give more details. (output of sh -x install.sh mqtt, without the fix that i merged now.)