remove install.sh (or maintain it better)

volkszaehler / vzlogger

Logging utility for various meters & sensors

http://wiki.volkszaehler.org/software/controller/vzlogger

GNU General Public License v3.0

145 stars 123 forks source link

remove install.sh (or maintain it better) #624

Open r00t- opened 10 months ago

r00t- commented 10 months ago

split from https://github.com/volkszaehler/vzlogger/issues/621

this is caused by a trivlal syntax error in install.sh, it seems that nobody ever tried to use the mqtt option before.

i would personally vote to remove install.sh, it's some attempt to make source installation easier, in a nonstandard ad-hoc way, and it's failing, as demonstrated here. we have (deb) packaging now, the issues that install.sh tries to solve (installation of dependencies) should have better and more standardized soltions. i.e. we have a redundant one with the dockerfile (which might aswell invoke install.sh, but chooses not to..

r00t- commented 10 months ago

further issues in a quick attempt to test install.sh:

it invoked ldconfig, failing because that's not on $PATH for non-root users,
then tries to invoke sudo, assuming it's running as a regular user
it assumes debian-like package names?

J-A-U commented 10 months ago

we have (deb) packaging now,

Install.sh would have been purged from wiki already if the deb-package had been working for me. https://lists.volkszaehler.org/pipermail/volkszaehler-users/2023-May/017042.html

we have a redundant one with the dockerfile

I'm not familiar with docker and nobody else seem to bother to document it in our wiki.

r00t- commented 10 months ago

@J-A-U:

Install.sh would have been purged from wiki already if the deb-package had been working for me. https://lists.volkszaehler.org/pipermail/volkszaehler-users/2023-May/017042.html

slightly off the topic, but i guess that's the bug that was reported and fixed at https://github.com/volkszaehler/vzlogger/issues/605 i'mafraid i stopped reading the -users list long ago, just too much noise.

narc-Ontakac2 commented 9 months ago

@J-A-U Could you please confirm if it is actually fixed.

I have added the armel architecture as a fix that should work on RPi 1. However I do not have the hardware to check it.

narc-Ontakac2 commented 6 months ago

If install.sh stays (and OMS is a strong argument to keep it) the vzlogger.service file should be aligned with the Debian version. Currently the service installed by install.sh runs as root. There are also other minor shortcomings.