local-themes.js instead of themes.js

volodymyr-lisniak / magento-2-gulp

Gulp for Magento 2. It works with core Magento styles (less) and structure. Uses default theme configs from dev/tools/grunt/configs/local-themes.js.

MIT License

41 stars 12 forks source link

local-themes.js instead of themes.js #3

Closed sprankhub closed 4 years ago

sprankhub commented 4 years ago

First, thanks for the awesome work!

I guess you agree when I say that it is bad practice to touch any core files. Hence, I kindly ask you to switch from the themes.js file to the local-themes.js file. See e.g.:

https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/tools/using_grunt.html#grunt_config https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/css-topics/css_debug.html#add_theme

volodymyr-lisniak commented 4 years ago

Thanks for your investment. I totally agree with this. And we already have merged pull request Please update to the new v1.3.4 version.