search

volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 100 forks source link

Repo selection not always most relevant #100

Closed adamalex closed 11 years ago

adamalex commented 11 years ago

James, great work with volo! It has been very convenient for us to work with in our library.

We have found that when installing we must qualify the name as "ExactTarget/fuelux" in order to get the correct repo. If we ask for just "fuelux" then one of the repo's forks are installed instead.

I was able to verify that the GitHub search api does not return our main repo as the first result, and I could not find anything in their documentation about how to change this order. Search link: https://api.github.com/legacy/repos/search/fuelux

Do you think it would be reasonable for volo to do something like the following:

  1. Install the repo with the specific name being searched for, with the highest number of forks or watchers
  2. Install only repos with "fork": false unless a qualified "USER/REPO" format is specifically requested

Or, do you have any other ideas for helping repo selection return the most relevant repo?

If you could provide your thoughts, I would appreciate it. If you like the idea but don't have the time to work on it I would be willing to take a stab at it myself as long as I know the idea fits your vision. In that case I'd appreciate your thoughts on how to split this up between the "search" and "resolve" logic. Thanks for everything!

jrburke commented 11 years ago

When I click on that search link, ExactTarget/fuelex seems to come up first now. I have noticed that whatever github is using for their search algorithm changes a bit over time. So, given that it now comes in first, does that solve it?

In general I prefer to not add my own search weightings on top of the existing github search, as I think it will be difficult to maintain. I do have a rule about favoring "search/search" over other values though.

The fork: false rule: I'm not sure that works out either. I would hope that github is grouping the results by most popular by whatever it measures as popular. I can see a fork being the canonical version after a while.

In short it is a bit tricky, and prefer to just leave it up to github, with folks advocating "owner/repo" to be specific. Going to close for now as part of bug triage, but we can continue discussion in the ticket and reopen if appropriate.

adamalex commented 11 years ago

Yes you are right, the GitHub search algorithm is looking much better since I last checked! Totally agree with your hands-off approach now that it looks like GitHub intends to apply reasonable weighting. Thanks for checking this out.