search

volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 99 forks source link

volo and d3 #121

Closed danse closed 11 years ago

danse commented 11 years ago

I know this is not a issue report with good quality, but... What is this?

volo add d3 Using github repo "mbostock/d3" for "d3"... Downloading: https://nodeload.github.com/mbostock/d3/legacy.zip/v2.10.3 No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/behavior/drag.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/behavior/behavior.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/behavior/zoom.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/pie.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/bundle.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/partition.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/chord.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/stack.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/treemap.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/force.js List any dependencies, comma separated, no spaces:
What global to use for exported value []:
No AMD/CommonJS dependencies detected for: www/js/lib/d3/src/layout/histogram.js

jrburke commented 11 years ago

This should be fixed now -- it was downloading the source repo when there is a built file, and it looks like you have a project with a package.json that has an "amd": {} property in it. When that happens it tries to convert the downloaded file to an AMD module, but does not have enough info to do so.

However, I updated the override repo to just use the built file, so doing a volo add d3 will now download the built d3.v2.js file, and the override repo has enough info to convert it to an amd module.

If you prefer to not have the dependency converted to something that is AMD-friendly, you can either remove that "amd" section from the package.json, or for a particular volo add command, pass it -amdoff.

danse commented 11 years ago

Oh yep, the amd: {} property was in the default package got from volo create.

Thanks!