search

volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 99 forks source link

code doesn't match comment #128

Closed jdalton closed 11 years ago

jdalton commented 11 years ago

I noticed that the comment and code here https://github.com/volojs/volo/blob/b3b8b39d0daee90239970ba95d3e8a322caa25fd/commands/amdify.js#L202-L207 don't match up.

The comment says "or if it does, does not declare define.amd." but the code is (amdProps.declaresDefine && amdProps.defineAmd) which suggests does declare define.amd.

jrburke commented 11 years ago

Thanks, fixed, will be part of 0.2.7.