search

volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 99 forks source link

volo add volojs/test-directory-main b/dirmain fails #143

Closed jrburke closed 11 years ago

jrburke commented 11 years ago

volo add volojs/test-directory-main b/dirmain seems to put the tempdir contents in the b/dirmain directory instead of the full directory.

Done in a project without a volo.baseDir.

Single file JS dependencies with a subdir work fine.

gregglind commented 11 years ago

I am getting some weird issues (still), even with loading previously "used to work" versions of my lib:

my volo is 0.2.8

Is there some way of debugging where the error is happening?

07 glind ~/gits/ctp-micropilot [git:master] $ volo add micropilot Using github repo "gregglind/micropilot" for "micropilot"... Downloading: https://nodeload.github.com/gregglind/micropilot/legacy.zip/master ERROR: Unexpected token name, expected punc (line: 76, col: 12, pos: 2118)

Error at new JS_Parse_Error (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:260:22) at js_error (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:268:15) at croak (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:721:17) at token_error (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:728:17) at expect_token (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:741:17) at expect (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:744:40) at regular_for (/usr/local/lib/node_modules/volo/nodemodules/uglify-js/lib/parse-js.js:926:17) at for (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:922:24) at /usr/local/lib/node_modules/volo/nodemodules/uglify-js/lib/parse-js.js:833:40 at block (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:986:32)

or:

719 glind ~/gits/ctp-micropilot [git:master+] $ volo install gregglind/micropilot/fb94770e20c7175ddfc9464afd65f45fdd399c08 Downloading: https://nodeload.github.com/gregglind/micropilot/legacy.zip/fb94770e20c7175ddfc9464afd65f45fdd399c08 ERROR: Unexpected token: punc ({) (line: 55, col: 7, pos: 1542)

Error at new JS_Parse_Error (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:260:22) at js_error (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:268:15) at croak (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:721:17) at token_error (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:728:17) at unexpected (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:734:17) at vardefs (/usr/local/lib/node_modules/volo/nodemodules/uglify-js/lib/parse-js.js:1043:33) at const (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:1064:36) at prog1 (/usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:1295:23) at /usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:866:40 at /usr/local/lib/node_modules/volo/node_modules/uglify-js/lib/parse-js.js:1280:32

jrburke commented 11 years ago

The issue is the "main" file for the download (lib/micropilot.js in this case) is parsed to see if it has dependencies. However, it is using JS 1.8, which the esprima parser does not support, so it threw up. I created a separate bug for this, #144, fixed it, and release version 0.2.9 of volo with it. So npm install -g volo to upgrade.