volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 100 forks source link

add doesn't respect localName for dependencies #54

Closed sammyt closed 12 years ago

sammyt commented 12 years ago

Awesome to see that #8 is closed and volo is starting to resolve dependencies. Just trying it out on one of my projects and have noticed that the localName argument is not respected for dependencies.

If I run the following command, where green has a dependency on blue

volo add green somewhere

The somewhere directory is created and green is added to it. Then add is called again with blue as the argument, only this time localName is not respected and so blue is added to the current directory not somewhere

Cheers

jrburke commented 12 years ago

I think this is working as designed: the localName is just for the current dependency, not for any nested dependencies, and all dependencies should be installed as siblings to each other. The localName thing is only there if you wanted to force a name to something else than what the volo picks. Otherwise, if localName was used for all dependencies, they would all be installed as the same name.

Reading more carefully, I may be making some assumptions. I'm assuming:

If I have that incorrect, I appreciate more details.