search

volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 100 forks source link

localName is incorrect when installing from a local path containing a dot #55

Closed brantb closed 12 years ago

brantb commented 12 years ago

Steps to reproduce

  1. git clone git://gist.github.com/2952133.git path.with.dots (link)
  2. volo create testapp && cd testapp
  3. volo add ../path.with.dots/

    Output

Downloading: http://code.jquery.com/jquery-1.7.2.js

Installed github:jquery/jquery/1.7.2 at www/js/lib/jquery.js
AMD dependency name: jquery
Installed local:/Users/brant/Code/path.with.spaces at www/js/lib/foo.bar.js
AMD dependency name: path.with

Volo uses the "path.with" as the AMD dependency name instead of "path.with.dots".

This can be worked around by specifying the dependency name explicitly (volo add ../path.with.dots/ path.with.dots), but the default behavior seems incorrect.

jrburke commented 12 years ago

Thanks for the great test case. It was a display issue, where it should have printed "foo.bar" as the AMD name. It is fixed in master, will be part of 0.2.1.