search

volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 99 forks source link

Package.json checking #61

Closed guybedford closed 11 years ago

guybedford commented 12 years ago

I have an application folder structure looking like:

-package.json -app.js -node_modules -www --js ---require.js ---jquery.js

If I am in the "www/js" folder and use "volo add", it creates a new package.json in the www/js folder.

Ideally, volo could check down all the folders until it finds the first package.json. If that package.json references the current folder as a baseUrl, it could use that package.json to ammend to?

jrburke commented 12 years ago

Makes sense. Related, or rather, do the same for volofiles, see #25

mstade commented 12 years ago

+1

DamonOehlman commented 12 years ago

@jrburke I'm happy to take this and #25 on as a good way to become more familiar with the volo code.

jrburke commented 12 years ago

@DamonOehlman great. I will not touch #25. Just leave comments in that ticket on if you decide not to look at it any more or if you have questions as you go. I will leave more comments in that ticket.

jrburke commented 12 years ago

I want to push out a 0.2.3, either by later tonight or by early Tuesday morning Pacific North America time, so I am going to push this to 0.2.4, as @DamonOehlman indicated he would probably need more time to get up to speed on the code, which I fully expect is not easy :).

If we get this going shortly after 0.2.3, I am more than happy to push out a 0.2.4 sooner rather than later. I expect this change will need more testing too once it lands but before it gets pushed out so we can all confirm our expectations with it.

DamonOehlman commented 12 years ago

Thanks James - that makes sense to me.

DamonOehlman commented 12 years ago

Sorry about the delay on this James - been a bit snowed under with some project handover I've been doing recently. Been doing some interesting work, but not a lot of time to spend on volo, hopefully will get a chance next week (if not sooner)...

jrburke commented 12 years ago

@DamonOehlman no worries. If it works out, it works out. It is also OK if it does not. The joy of open source contributing is that you are not required to do it. If at some point I get around to looking at this, then I'll ping in this ticket before starting any work. I do not have any immediate plans to do so though.

jrburke commented 11 years ago

I'm going to punt on this for now. Node does this and it has actually bitten me a few times were it installed something up higher than I wanted, and cleaning that up is harder to figure out.

So, going to leave this as-is for now, where it will leave a local package.json, which gives an indication of what may be wrong if the developer actually wanted a parent package.json modified, but at least the install happens locally, and it is easier to do a manual add to the parent package.json later than to do a cleanup of an incorrectly placed version.

I'm open to more feedback that this is a bigger problem, even more open to a patch that would do the change -- although no guarantees it will get in. But closing this until there is a more active champion for it.