volojs / volo

Create front end projects from templates, add dependencies, and automate the resulting projects
https://volojs.github.io/
Other
1.41k stars 99 forks source link

volo add localName should allow directory/path #90

Closed sfoster closed 12 years ago

sfoster commented 12 years ago

Trying to arrange dependencies in package-style directories like volo add jquery dollar/main results in an error like:

events.js:66
        throw arguments[1]; // Unhandled 'error' event
                       ^
Error: ENOENT, open '/var/folders/ms/fymsvt0x1nlggn8yhg4lyqfm0000gp/T/temp-dollar-main-1346345909943-1/download/dollar/main.js'

This is true if the directory already exists or not.

jrburke commented 12 years ago

Fixed now on master. Although this is discouraged as far as trying to get "package feel" for single JS libs. The baseUrl + moduleId + '.js' is great "code by convention" that avoids configuration boilerplate and encourages people to distribute specialized single purpose modules instead of module grab bags.

All that said, the above command needs to be work regardless -- it should be possible to install jquery in a subdirectory under baseUrl. Thanks for the report!