voloko / twitter-stream

Twitter realtime API client
MIT License
233 stars 81 forks source link

Reconnect with updated content #10

Open hotwoofy opened 13 years ago

hotwoofy commented 13 years ago

The README asserts that twitter-stream adheres to twitter's reconnection guidline, so I've been happily exposing the @options variable, modifying the :content to change track keywords, and issueing immdiate_reconnect to update things when I recieve SIGUSR1.

I've had no problems, I was purely wondering if there was anything I should worry about with this approach? Is there any reason this couldn't be explicitly exposed in future releases?

thbar commented 12 years ago

@hotwoofy does it still work for you today?

I'm having issues here, namely this exception just after what doing what you describe:

[GEM_ROOT]/gems/twitter-stream-0.1.14/lib/twitter/json_stream.rb:121:in `<<'
[GEM_ROOT]/gems/twitter-stream-0.1.14/lib/twitter/json_stream.rb:121:in `receive_data'
[GEM_ROOT]/gems/eventmachine-1.0.0.beta.4/lib/eventmachine.rb:179:in `run_machine'
[GEM_ROOT]/gems/eventmachine-1.0.0.beta.4/lib/eventmachine.rb:179:in `run'

It happens even with the current master.

Do you have something that works today?

More details:

stream.options[:content] = new_content
stream.immediate_reconnect

Then I receive 2 on_reconnect then the error above, all the time.

Let me know if you have a fix!

thbar commented 12 years ago

@hotwoofy I created issue #27 to track the exception I got