search

volotat / SD-CN-Animation

This script allows to automate video stylization task using StableDiffusion and ControlNet.
MIT License
806 stars 61 forks source link

Notice: extension is incompatible with webui 1.8, pending removel form extension index #206

Open w-e-w opened 6 months ago

w-e-w commented 6 months ago

@volotat Hi I'm am the maintainer of https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions

base on user report and my testing seems that this extension is critically incompatible with the current release of webui 1.8 and for my testing this is the case

webui 1.8 will crash will crash on launch with this extension enabled

I believe the root cause stems from the unorthodox initialization of scritps at https://github.com/volotat/SD-CN-Animation/blob/4f07b5e6d22a9dd2edbb8c5a2c5e6f5678b130de/scripts/base_ui.py#L165-L166 from my quick testing removeing at least two lines would allwo webui to launch and even will allow user to use SD-CN-Animation to operate at least partially, during operation image seems to generate but lots of exceptions are thrown mainly one's related to other extensions caused by this extension

earlier versions of web UI does not crash completely but still exhibits lots of similer issues

judging by the lack of activity I believe this extension is no longer maintained as such my intention is to remove the extension from extention index until it is fixed, or redirect the URL to a usable fork if exist

there is no update on the status of this extension I will remove it from index after 1 week for now I will add a description on index informing user that this is no longer compatible https://github.com/AUTOMATIC1111/stable-diffusion-webui-extensions/commit/7f46c1df7086e5b331b3b564e4aa2a91baf6d93a

if this extension is fixed in the future or if anyone is willing to continue maintaining a fork please contact so it can be relisted on the index

1manfactory commented 5 months ago

too bad. it still works somehow, at least on windows ports. But it is only a matter of time until it will stop working.

w-e-w commented 5 months ago

too bad. it still works somehow, at least on windows ports. But it is only a matter of time until it will stop working.

is this still working on 1.8?

btw I haven't actually remove it from the index

1manfactory commented 5 months ago

Yes, it works But with some errors in the console

** Error running post_sample: C:\sd.webui\webui\extensions-builtin\soft-inpainting\scripts\soft_inpainting.py1.12s/it] Traceback (most recent call last): File "C:\sd.webui\webui\modules\scripts.py", line 840, in post_sample script.post_sample(p, ps, script_args) TypeError: Script.post_sample() takes 10 positional arguments but 248 were given

** Error running postprocess_image: C:\sd.webui\webui\extensions-builtin\soft-inpainting\scripts\soft_inpainting.py Traceback (most recent call last): File "C:\sd.webui\webui\modules\scripts.py", line 864, in postprocess_maskoverlay script.postprocess_maskoverlay(p, ppmo, script_args) TypeError: Script.postprocess_maskoverlay() takes 10 positional arguments but 248 were given

Am Fr., 12. Apr. 2024 um 12:53 Uhr schrieb w-e-w @.***>:

too bad. it still works somehow, at least on windows ports. But it is only a matter of time until it will stop working.

is this still working on 1.8?

— Reply to this email directly, view it on GitHub https://github.com/volotat/SD-CN-Animation/issues/206#issuecomment-2051530563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYZYVGVEJVU3EQ3ZCWEUTY464KZAVCNFSM6AAAAABERDO66GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGUZTANJWGM . You are receiving this because you commented.Message ID: @.***>

-- Jürgen Schulze @.***

w-e-w commented 5 months ago

TypeError: Script.post_sample() takes 10 positional arguments but 248

yeah I'd remember seeing something similar irrc that it is one of the errors caused by this extension (even though you see that the error is triggered by a built-in extension)

this extension is implemented in a way that's very easily broken or would cause other things to break if there's any change in web UI

1manfactory commented 5 months ago

I removed it because it really seems to crash some other extension. Too bad

Am Fr., 12. Apr. 2024 um 12:53 Uhr schrieb w-e-w @.***>:

too bad. it still works somehow, at least on windows ports. But it is only a matter of time until it will stop working.

is this still working on 1.8?

— Reply to this email directly, view it on GitHub https://github.com/volotat/SD-CN-Animation/issues/206#issuecomment-2051530563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYZYVGVEJVU3EQ3ZCWEUTY464KZAVCNFSM6AAAAABERDO66GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRGUZTANJWGM . You are receiving this because you commented.Message ID: @.***>

-- Jürgen Schulze @.***