volsa / etherface

Ethereum Signature Database
https://www.etherface.io
GNU General Public License v3.0
171 stars 22 forks source link

scrape polygonscan, bscscan #15

Open allenday opened 1 year ago

allenday commented 1 year ago

identical API to etherscan

volsa commented 1 year ago

I'll see if I can find some time this week to work on this, should in theory be fairly simple as they're 1:1 clones of Etherscan with only a different stylesheet. Anyways, on top of my head I can think of two approaches to implement this:

  1. Introduce a polygonscan_contract and bscscan_contract table with the same structure as etherscan_contract or
  2. Introduce a network enum field into etherscan_contract which can either by ethereum, polygon or binance; also make the address and network fields into an unique tuple to avoid collisions.

Any thoughts?

Edit: Also does #9 apply here?

allenday commented 1 year ago

it's also a different API key

  1. yes, works for me
  2. either way - whatever is less work since I'll be using DBT to transform them post-load to BQ anyway.
allenday commented 1 year ago

RE #9 we have Polygon in BQ but not yet BNBChain