search

volsahin / volx-recyclerview-fast-scroll

An easy to use implementation for fast scroll recyclerview
34 stars 8 forks source link

Clear indexes before regenerating them #7

Closed captaintouch closed 5 years ago

captaintouch commented 5 years ago

Hi!

I noticed that when calling notifyValueDataChanged() the new indexes were appended at the end instead of replacing them all. The changes in this pull request clear the corresponding arrays before adding the contents to them again.

volsahin commented 5 years ago

Can you please move these lines to a separate method and call it in notifyValueDataChanged method since clearing them in execute method for the first time is pointless because the lists are empty. Thank you for your commit.

captaintouch commented 5 years ago

Can you please move these lines to a separate method and call it in notifyValueDataChanged method since clearing them in execute method for the first time is pointless because the lists are empty. Thank you for your commit.

Makes sense, thanks, updated the PR.