volta-cli / action

GitHub Action to Setup Volta
https://volta.sh
MIT License
93 stars 23 forks source link

Action fails to download `volta@1.1.0` #117

Closed twokul closed 2 years ago

twokul commented 2 years ago

volta-cli/action started failing suddenly today.

Here are the errors that I have observed:

Using volta-cli/action@v1

Run volta-cli/action@v1
downloading volta@1.1.0
Object prototype may only be an Object or null: undefined
Waiting 14 seconds before trying again
Object prototype may only be an Object or null: undefined
Waiting 1[6](https://github.com/<reducted>/<reducted>/actions/runs/3267621963/jobs/5373337030#step:3:7) seconds before trying again
Error: Object prototype may only be an Object or null: undefined

Using volta-cli/action@v3

Run volta-cli/action@v3
looking up latest volta version from https://volta.sh/latest-version
downloading volta@1.1.0
/usr/bin/openssl version
OpenSSL 1.1.1f  31 Mar 2020
Error: Unexpected HTTP response: 404

The volta-cli@1.1.0 seems to be available (and has been for some time.)

Interestingly enough, pinning the version to 1.0.8 "fixes" the errors:

- uses: volta-cli/action@v3
  with:
   volta-version: 1.0.8

Any pointers?

FiberJW commented 2 years ago

I'm getting the same error ^

na-ji commented 2 years ago

Upgrading to volta-cli/action@v4 fixed the issue for me.

rwjblue commented 2 years ago

Ya, volta@1.1.0 requires volta-cli/action@v4

twokul commented 2 years ago

@rwjblue Understood. The issue is that v3 and earlier versions pull the latest version of volta (1.1.0.) It seems like that might be an unintentional breaking change.

rwjblue commented 2 years ago

I'm working on backports of #115. The problem here is basically that there is an unfortunate coupling between volta's own publishing process (where we have to figure out what asset to install for any given platform). From the volta-cli/volta perspective there is no breaking change (since it's installer script does the right thing), but for users of the action things are not as smooth at the moment.

I'll try to create an issue and start strategizing how to absorb things a bit better "next time", in the meantime I'm trying to backport fixes to applicable versions of the action.

charlespierce commented 2 years ago

Apologies to those impacted, this was my mistake not coordinating the changes before publishing the Volta release 😢

rwjblue commented 2 years ago

OK, all majors have been updated (v1, v2, v3, and v4), sorry for the troubles!!

twokul commented 2 years ago

@rwjblue thanks much!