search

volta-cli / action

GitHub Action to Setup Volta
https://volta.sh
MIT License
93 stars 23 forks source link

Unexpected input(s) 'scope' #94

Closed breningham closed 2 years ago

breningham commented 2 years ago

it's accessed in the code here: https://github.com/volta-cli/action/blob/000034ba643d3985197785c24793ed8e19ea6478/src/registry.ts#L24

but it's not provided in the action.yml's accepted inputs.

rwjblue commented 2 years ago

Eeck!!! thank you for reporting!!

rwjblue commented 2 years ago

@breningham - I am curious how you get a warning? I was just reviewing our test suite (which does execute this code path), but I don't see any warnings or errors like this. Is there a "strict mode" flag or something that I should try to enable that would cause things to error (in order to prevent this sort of mixup again)?

breningham commented 2 years ago

Honestly i just got the warning because i tried to use it 😆

eslint could probably be used to check this sort of thing - not sure if such a thing already exists or not though.

rwjblue commented 2 years ago

Fixed in v2.0.2 (also v2 tag), thanks for reporting!