search

volta-cli / rfcs

RFCs for changes to Volta
Other
17 stars 14 forks source link

RFC: Config -> Hooks #25

Closed charlespierce closed 5 years ago

charlespierce commented 6 years ago

Rename Config to Hooks and allow additional methods for specifying tool resolution.

Rendered

charlespierce commented 5 years ago

Another open question that just came to me: Should the hooks file(s) be .toml, or .json files? While .toml is an exceedingly simple format, the end-users of the tool ultimately are JS devs. They will already be familiar with JSON, so it might reduce friction to have the hooks / file-based configuration be in JSON format.

dherman commented 5 years ago

@charlespierce Fair question Re: TOML; the unfamiliarity is an onboarding tax for JS devs. OTOH, comments! :P

I think we should stick with TOML for now and wait to see how loudly people complain. Configuring hooks isn't something people will typically do in normal workflows anyway.

dherman commented 5 years ago

This looks great! I'm going to mark it as being in final comment period and announce it to the channel.

rwjblue commented 5 years ago

I think we should stick with TOML for now and wait to see how loudly people complain. Configuring hooks isn't something people will typically do in normal workflows anyway.

I tend to agree here.

chriskrycho commented 5 years ago

This has been in FCP for just shy of three months. Should it be marked as accepted and merged… especially since the implementation is already merged? 😁