search

volta-cli / rfcs

RFCs for changes to Volta
Other
17 stars 14 forks source link

RFC: migrate from Docopt to StructOpt #30

Closed chriskrycho closed 5 years ago

chriskrycho commented 5 years ago

Use StructOpt to get automatic coloration, completions, and (in the author's experience) easier development and maintenance.

Rendered

chriskrycho commented 5 years ago

Happily, no, because we won't actually be using the template field at this point – if it ends up being useable for us later, it would be if we made e.g. ansi_term support const fn (if that's possible; it may not be!) and thus got its cross-platform support baked in for free. The basic colorization stuff all Just Works cross-platform out of the box.

dherman commented 5 years ago

I'm 👍 on this. I like DocOpt but agree that the runtime parsing, unhelpful errors, and lack of documentation around the input grammar are problematic. And generally I think it's not super actively maintained so that's probably another good reason to switch.

chriskrycho commented 5 years ago

Thanks, @dherman and @charlespierce – I've updated the RFC to clarify those points!

dherman commented 5 years ago

Discussion on this RFC has stabilized and the implementation has already landed and is working out. I'm marking this as final comment period and we can probably merge soon.