Create ARM Linux Build using cross-rs - Githubissues

volta-cli / volta

Volta: JS Toolchains as Code. ⚡

https://volta.sh

Other

10.33k stars 220 forks source link

Create ARM Linux Build using cross-rs #1696

Closed charlespierce closed 4 months ago

charlespierce commented 4 months ago

Info

We already support both ARM and x64 for macOS, we can do the same for Linux with cross-rs without needing too much extra work.
Since this is a new build that we haven't previously supported, we don't need to adhere to the same binary compatibility guarantees that we are currently using for x64 Linux.

Changes

Updated the release.yml GitHub actions file to also generate an ARM build for Linux
- This takes advantage of cross-rs, which makes the compilation process very straightforward and fast.
Updated volta-install.sh to properly handle Linux ARM builds.

Tested

Downloaded the artifacts generated in CI and validated that they work in a Linux Docker container on an ARM MacBook.

Notes

Do we also need to update COMPATIBILITY.md to reflect the slightly more complicated compatibility that we support (since the ARM builds are made on a newer system)?

this-is-tobi commented 3 months ago

Hello, thanks for the work, it's exciting to continue using volta on any type of system !

Just a question, is there a release planned to get the new linux-arm64 binary ?