volta-cli / volta

Volta: JS Toolchains as Code. ⚡
https://volta.sh
Other
11.02k stars 231 forks source link

Investigate VS Code Git Tools & Pre-commit #516

Open charlespierce opened 5 years ago

charlespierce commented 5 years ago

If your project has a pre-commit hook that calls a Node command, and you use VS Code Git Tools to initiate a commit, Volta appears to be finding the default Node instead of the Node specified in package.json.

A possible cause of this is VS Code is somehow executing the Git commit with a cwd that is outside of the project, causing Volta to start in the wrong directory and not find the project-local settings. If possible, we should correctly handle this case, or worst provide some guidance for how to set up VS Code to get the expected behavior.

vesamet commented 3 years ago

I'm also having this issue.