voltapp / volt

300 KB desktop client for Slack, Skype, Twitter, Telegram, and more
608 stars 8 forks source link

crash when selecting a channel from a removed slack #109

Closed coffeejunk closed 5 years ago

coffeejunk commented 5 years ago

Version: volt v0.55

Repro steps:

  1. Add a Slack and let the messages & channels sync
  2. Add a second Slack and let the messages & channels sync
  3. Remove the second Slack
    • the channels from the removed Slack remain
  4. Select one of the channels from the removed Slack
    • Volt crashes silently

Log:

2019-02-18 14:38:21.067 volt[37871:28731442] load chat - OK
exiting from os.exit(): slack api not found
2019-02-18 14:38:21.078 volt[37871:28731442] slack api not found
voltapp2 commented 5 years ago

Thanks for the detailed report.

I know what the problem is.

Do you only get the crash in this scenario? No more crashes on launch?

On Feb 18, 2019, at 20:43, Maximilian Haack notifications@github.com wrote:

Version: volt v0.55

Repro steps:

Add a Slack and let the messages & channels sync Add a second Slack and let the messages & channels sync Remove the second Slack the channels from the removed Slack remain Select one of the channels from the removed Slack Volt crashes silently Log:

2019-02-18 14:38:21.067 volt[37871:28731442] load chat - OK exiting from os.exit(): slack api not found 2019-02-18 14:38:21.078 volt[37871:28731442] slack api not found — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/voltapp/volt/issues/109, or mute the thread https://github.com/notifications/unsubscribe-auth/AcdpOH7x1rGoi9Yj8t38RYdwn5y6MnITks5vOwJPgaJpZM4bBgYL.

coffeejunk commented 5 years ago

Yep, this is the only crash I'm observing right now.

voltapp2 commented 5 years ago

Great, thanks! I’ll fix this one later today.

On Feb 18, 2019, at 20:45, Maximilian Haack notifications@github.com wrote:

Yep, this is the only crash I'm observing right now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/voltapp/volt/issues/109#issuecomment-464855136, or mute the thread https://github.com/notifications/unsubscribe-auth/AcdpOHIKYDqIRlFqPmZXIFlvgnzKX_sZks5vOwLCgaJpZM4bBgYL.

voltapp2 commented 5 years ago

Fixed in 0.81